This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
Fix for crash when search includes white-space - #1950
Merged
Merged
Conversation
SearchAsync will crash the process if we send it a duplicate string. There is a SearchTrimsWhitespace setting that makes searched with leading or trailing white-space appear as duplicates. We compare the query with trimmed white-space to avoid this.
jcansdale
force-pushed
the
fixes/1948-search-white-space
branch
from
September 25, 2018 09:47
44dd35c to
871c112
Compare
Contributor
|
This LGTM @jcansdale! |
grokys
approved these changes
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchAsync will crash the process if we send it a duplicate string. There is a SearchTrimsWhitespace setting that makes searched with leading or trailing white-space appear as duplicates. We compare the query with trimmed white-space to avoid this.
Fixes #1948